Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hard coded line separators with system specific ones in SMT checker #1971

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

yqszxx
Copy link
Contributor

@yqszxx yqszxx commented Jun 23, 2021

Hard coded \n results in false-positive assertion failures and confusing error messages in SMT checker when using Z3 on Windows.

The output log was: java.lang.AssertionError: assertion failed: Unexpected output: unsat but unsat is actually an acceptable output.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix

API Impact

No.

Backend Code Generation Impact

No.

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.x, 3.5.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@sequencer sequencer merged commit aaccf17 into chipsalliance:master Jun 23, 2021
@ekiwi
Copy link
Contributor

ekiwi commented Jun 23, 2021

@yqszxx
Copy link
Contributor Author

yqszxx commented Jun 23, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants